Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not fail SLOW tests if they are not slow #25868

Closed
wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Feb 1, 2019

Make SLOW imply PASS.

Refs: #25867

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Feb 1, 2019
@addaleax
Copy link
Member

addaleax commented Feb 2, 2019

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2019
@hashseed
Copy link
Member Author

hashseed commented Feb 4, 2019

Looks like some Jenkins related issue?

@refack
Copy link
Contributor

refack commented Feb 4, 2019

Looks like some Jenkins related issue?

Should be solved.
Resume: https://ci.nodejs.org/job/node-test-pull-request/20562/ ✔️

@refack refack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 4, 2019
@refack
Copy link
Contributor

refack commented Feb 4, 2019

Landed in dfe5f8f

@refack refack closed this Feb 4, 2019
refack pushed a commit that referenced this pull request Feb 4, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@hashseed hashseed deleted the slowtests branch February 15, 2019 12:49
BethGriggs pushed a commit that referenced this pull request Dec 4, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants